Support for degree Celsius and conversions from/to Kelvin
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 146
- Forks
- 23
- Avg merge
- 2d 7h
- Merged PRs (30d)
- 7
Description
As far as I can tell degree Celsius are currently not supported by the string parsing? This should be fixed.
To make it actually useful, we have to support conversion from/to Kelvin. Currently we use llnl::units::quick_convert, which does not work in this case. We should switch to (or fall back to) llnl::units::convert in this case.
We should also check that we store the e_flag field when writing HDF5 files, or handle this in some other way.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the string-parsing path for units and the uses of llnl::units::quick_convert and convert, then inspect HDF5 writing for the e_flag field. Done means degree Celsius parses correctly, conversions to and from Kelvin work, and e_flag is stored or otherwise handled when writing HDF5 files.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- data
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100