Mesh3D plot: positions do not update
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 12
- Forks
- 6
- PR merge metrics
- No merged PRs in 30d
Description
Example:
import scipp as sc
import plopp as pp
from plopp.data import examples
dg = sc.io.load_hdf5(examples.teapot())
v = pp.Node(dg["vertices"])
f = pp.Node(dg["faces"])
c = pp.Node(dg["vertices"].fields.z)
fig = pp.mesh3d(
vertices=v,
faces=f,
vertexcolors=c,
)
fig
and then
v.func = lambda: dg["vertices"] * 2.0
v.notify_children("")
has no effect.
See TODO in the code.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the example in the issue, then read src/plopp/backends/pythreejs/mesh3d.py at the linked TODO. Trace how v.notify_children("") reaches the mesh and determine why changed vertex positions are not reflected; done when updating v causes the displayed mesh positions to change.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data-visualization
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 58/100