[esssans] Replace loki instrument view with the generic scippneutron instrument view
Open
Beginner friendly
Nobody has claimed this yet.
esssans
- Dominant language
- Python
- Stars
- 1
- Forks
- 3
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 17
Description
We no longer need the from ess.loki.diagnostics.InstrumentView as the scippneutron's generic instrument view should handle the loki dete well, and with better performance.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the repository for imports or uses of ess.loki.diagnostics.InstrumentView and read the surrounding Loki instrument-view entry point. Compare it with scippneutron's generic instrument view documentation, then verify that Loki uses the generic view and that the old import is no longer needed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data-visualization
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100