scipp / scipp/ess

[ESSDIFFRACTION, BEER] Add coordinates to dataarrays in Sciline pulse shaping workflow

Open
#744 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1
Forks
3
Avg merge
2d 11h
Merged PRs (30d)
17

Description

The following coordinates should be added in the dataarrays of the pulse shaping workflow for BEER:

  • lambda_min and Ltotal (chopper → detector) as coordinates to RawDetector.
  • for saving data to xye file (ToF, intensity, error) as the final reduction step, we need Ltot and 2theta in DspacingIntensity to calculate the coefficient between d-spacing and Tof.
  • To identify the modes of operation, other metadata, such as centre wavelength (lambda_0), L1 , L2, MC chopper frequency are needed in the data arrays

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the BEER pulse shaping workflow and inspect the RawDetector and DspacingIntensity dataarrays. Add the requested wavelength, flight-path, angle, and operation metadata coordinates, then verify that the final xye-saving reduction has the ToF, intensity, error, Ltot, and 2theta data needed for d-spacing conversion.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.