scipp / scipp/ess

[ESSSANS] Direct beam: dealing with insufficient signal

Open
#717 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

esssans
Dominant language
Python
Stars
1
Forks
3
Avg merge
2d 11h
Merged PRs (30d)
17

Description

Based on chat with Judith about direct-beam iteration:

  • NaN-regions should probably be masked, or else we will get NaN in the workflow result. Should we mask the direct beam file, or should the reduction workflow perform its own masking?
  • Should NaN-regions be "filled" with approximate values based on non-NaN neighbours?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the direct-beam iteration and reduction workflow referenced in the issue. Decide whether NaN regions belong masked in the direct-beam file or in the workflow, and whether neighbouring values should fill them; done means the chosen behavior prevents invalid workflow results and is documented or tested.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.