scipp / scipp/ess

Broadcast uncertainties

Open
#572 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

essspectroscopy
Dominant language
Python
Stars
1
Forks
3
Avg merge
2d 11h
Merged PRs (30d)
17

Description

          > Does the result from broadcast_uncertainties work with scipp.loookup?

It should. We use it here: https://github.com/scipp/essdiffraction/blob/149203c29be6dd6e5dc49bf910015b308c0afa9e/src/ess/powder/correction.py#L56-L59

The monitor uncertainties are necessarily large at the minimal and maximal wavelengths transported by the guide, where the incident intensity goes to zero -- but the uncertainty relative to the detector uncertainty is probably always small due to the small cross section for inelastic scattering.

I think this deserves some more investigation once we have the full workflow. We should ensure that we can ignore correlations around the edges of the data. Or avoid using those data.

Originally posted by @jl-wynen in https://github.com/scipp/essspectroscopy/pull/24#discussion_r1810122797

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by examining the use of broadcast_uncertainties in essdiffraction/src/ess/powder/correction.py at lines 56-59, then trace how its result is used with scipp.lookup. Investigate uncertainty correlations at the minimum and maximum transported wavelengths; the work is done when the workflow establishes whether edge correlations can be ignored or the affected data should be excluded.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.