Replace hard coded vectors
Open
Nobody has claimed this yet.
essspectroscopy
- Dominant language
- Python
- Stars
- 1
- Forks
- 3
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 17
Description
There are a number of hard-coded vectors in the code. Mostly for the scattering vectors and plane. Those can all be derived from the source and sample position as well as gravity. So we should replace the hard-coded values to be more agnostic to the coordinate system.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the codebase for hard-coded scattering vectors and plane values, then trace how source position, sample position, and gravity are represented. Determine where those values are constructed and check the relevant reduction tests or workflows. Done means the vectors are derived from those inputs and no longer depend on a fixed coordinate system.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100