More robust grouping by angle
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1
- Forks
- 3
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 17
Description
The BIFROST workflow groups by sample and detector angle a3 and a4. The implementation needs to be extended for:
- Varying
a4. - Intermediate angle values that are recorded while the sample or detector moves. Those time regions likely need to be discarded.
The implementation also needs to be benchmarked for long measurements with many log entries for the angles. We may be better off, avoiding sc.lookup in that case and determine bin edges first and then bin by those edges.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the BIFROST workflow that groups by sample and detector angles a3 and a4, then inspect how sc.lookup is used. Reproduce grouping with varying a4 and intermediate movement values, and benchmark long measurements with many angle log entries; done means movement regions are discarded and grouping remains correct and performant.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100