Does empty-can subtraction need to take bin widths into account?
Open
Nobody has claimed this yet.
essdiffraction
- Dominant language
- Python
- Stars
- 1
- Forks
- 3
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 17
Description
Similarly to scipp/ess#486 and scipp/ess#485, do we need to scale by the bins widths of sample and empty can runs before subtraction?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the related scipp/ess#486 and scipp/ess#485 discussions, then locate the empty-can subtraction implementation and how sample and empty-can bin widths are represented. Determine whether subtraction requires bin-width scaling; done means the behavior is decided and covered by an appropriate regression test or documented rationale.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100