scipp / scipp/ess

Wavelength calibration when using d-spacing from calibration table?

Open
#482 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

essdiffraction
Dominant language
Python
Stars
1
Forks
3
Avg merge
2d 11h
Merged PRs (30d)
17

Description

Consider the workflow mode computing d-spacing from a diffraction calibration table. This directly takes TOF as input. However, monitor normalization still computes wavelength using the "regular" math from TOF. In a sense, this bypasses the calibration. If the monitor does have pronounced features (such as between the WFM frames?), this might lead to inaccuracies.

Does the wavelength need calibration, somehow?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by tracing workflow mode where d-spacing is computed from the diffraction calibration table, then compare that path with monitor normalization's wavelength calculation from TOF. Done means establishing whether wavelength also needs calibration and documenting the required behavior or scope.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.