d-spacing from calibration: use toa, not tof
Open
Nobody has claimed this yet.
essdiffraction
- Dominant language
- Python
- Stars
- 1
- Forks
- 3
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 17
Description
We have incorrectly been using tof as the input for computing d-spacing with claibration. It should actually be toa. This matters at ESS.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named. Search the calibration d-spacing implementation for where tof is used, then trace the relevant ESS data flow to confirm toa is available there. Done means the calibration calculation uses toa rather than tof and the ESS reduction produces the intended d-spacing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100