scipp / scipp/ess

Generalize supermirror efficiency function to be not wavelength dependent

Open
#407 0 comments 0 reactions 1 assignee View on GitHub

@jokasimr is already working on this.

Since May 26, 2025.

esspolarization
Dominant language
Python
Stars
1
Forks
3
Avg merge
2d 11h
Merged PRs (30d)
17

Description

Right now the supermirror efficiency function is assumed to be wavelength dependent.
This is correct in principle, but in some cases it can be useful to use an efficiency function that is not wavelength dependent.

This can happen if it is easier to accurately estimate the efficiency parameters as functions of Q than it is to estimate them as functions of wavelength.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.