Handling NaN values in efficiency tables?
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1
- Forks
- 3
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 17
Description
The polarization correction workflow computes and applies scale factors to the data. If the data events are bins have masks, those will simply be preserved.
If the efficiency table has nan values, we are currently not handling this explicitly, I think, i.e., the nans will propagate. I will open an issue so we can think/discuss the best way of handling this.
Originally posted by @SimonHeybrock in https://github.com/scipp/esspolarization/pull/94#discussion_r2134971304
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the polarization correction workflow and the PR #94 discussion that raised this issue. Determine the intended behavior for NaN values in efficiency tables while preserving event-bin masks, then validate the chosen behavior against representative data and define a clear completion criterion.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100