SANS beam center correction may need to be applied differently
Open
Nobody has claimed this yet.
esssans
- Dominant language
- Python
- Stars
- 1
- Forks
- 3
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 17
Description
Based on Slack discussion in #dmsc-loki:
Currently the correction is applied as a fixed shift to all pixels. However, since LoKI has banks at different Z this may be incorrect.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the current SANS beam center correction implementation and review how the fixed pixel shift is calculated for LoKI. Determine how differing bank Z positions affect the correction, then add or update focused coverage showing the expected behavior for banks at different Z.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100