scipp / scipp/ess

Offspecular coordinate transformation

Open
#284 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

essreflectometry
Dominant language
Python
Stars
1
Forks
3
Avg merge
2d 11h
Merged PRs (30d)
17

Description

In offspecular reflectometry we have additional coordinates like Q_x, and the definition of other coordinates might change a bit (not 100% sure).

See https://journals.iucr.org/paper?s0021889811002858.

We should probably address this by adding a new coordinate transformation graph.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the cited IUCr paper and inspecting the repository's existing coordinate transformation graphs. Clarify the offspecular coordinate definitions, including Q_x and any changed coordinates, then define the required transformation graph. Done means the graph represents the paper's coordinate system and is covered by appropriate validation.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.