[Essreduce]: Remove 'position' coordinate from WavelengthDetector
Open
Beginner friendly
Nobody has claimed this yet.
essreduce
- Dominant language
- Python
- Stars
- 1
- Forks
- 3
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 17
Description
Once the data is converted to wavelength in the generic workflow here, we have assigned a Ltotal coordinate.
We should also remove the position coordinate on the data as it causes issues when trying to normalize with monitors that have different positions (e.g. see https://github.com/scipp/esssans/pull/246).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in packages/essreduce/src/ess/reduce/time_of_flight/eto_to_tof.py at the generic workflow around the cited Ltotal assignment and inspect the coordinates present after conversion to wavelength. Remove the position coordinate there, then verify that normalization works with monitors at different positions and that Ltotal remains available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 72/100