Use scippnexus to save nexus files
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1
- Forks
- 3
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 17
Description
Currently we are using h5py in quite a few place.
We should probably use scippnexus for consistency.
https://github.com/scipp/essnmx/blob/be53f9caffdcd34dc876404320064cd4d8178576/src/ess/nmx/nexus.py#L361-L362
https://github.com/scipp/essnmx/blob/be53f9caffdcd34dc876404320064cd4d8178576/src/ess/nmx/nexus.py#L398-L399
Especially here we need compression for counts so that requires some update in scippnexus.
It can be useful for other instruments as well: https://github.com/scipp/essnmx/pull/130#pullrequestreview-2721557853
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/ess/nmx/nexus.py at the referenced lines 361-362, 398-399, and 431-494, then review scippnexus and the linked essnmx pull-request review. Determine how scippnexus can replace the current h5py saving paths and support compression for counts. Done means the relevant Nexus files use scippnexus consistently, including compressed counts.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100