scipp / scipp/ess

Check all positions are with respect to the sample

Open
#190 0 comments 0 reactions 1 assignee View on GitHub

@YooSunYoung is already working on this.

Since Feb 18, 2026.

bug essnmx
Dominant language
Python
Stars
1
Forks
3
Avg merge
2d 11h
Merged PRs (30d)
17

Description

For now, the nexus reduction workflow assumes that the sample is at (0,0,0).
It might not be the case in the real nexus files so we should make sure that all positions are with respect to the sample position...

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.