Default value for lookup table relative error threshold.
Open
Nobody has claimed this yet.
essreduce
- Dominant language
- Python
- Stars
- 1
- Forks
- 3
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 17
Description
Can we have a default value of this LookupTableRelativeErrorThreshold so that we can just set an empty dictionary as a default parameter...?
Or do we always want to explicitly set the error threshold...?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read the LookupTableRelativeErrorThreshold usage at packages/essreduce/src/ess/reduce/time_of_flight/eto_to_tof.py:453 and the default parameter flow in packages/essreduce/src/ess/reduce/time_of_flight/workflow.py:83-91. Determine whether an empty dictionary can be the default while preserving explicit error thresholds; done means the default behavior is defined and existing explicit configuration remains supported.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100