scikit-learn / scikit-learn/scikit-learn

[Callbacks] Add mechanism to realiably re-set `max_subtasks` on `CallbackContext`?

Open
#33,783 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Callbacks
Dominant language
Python
Stars
67.3k
Forks
27.4k
Avg merge
1d 15h
Merged PRs (30d)
58

Description

[!WARNING]
This issue is not yet ready for a PR. If you are interested in contributing to scikit-learn, please have a look at our contributing guidelines, and in particular the sections for new contributors and the "Needs triage" label.

Not a high priority, but as @adrinjalali hinted and we discussed yesterday in the meeting:

We may consider to add a mechanism to re-set the max_subtasks on CallbackContext, so that progress bars can be re-scaled when new information on the maximum number of sub-tasks is available on an estimator or meta-estimator.

Currently, setting the max_subtasks after creating a new subcontext, we'd not be sure if this would update the total on a ProgressBar.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the CallbackContext and ProgressBar implementations, focusing on how subcontexts and the progress-bar total are related. The issue is complete when a reliable mechanism exists to reset max_subtasks after new estimator or meta-estimator information arrives and the progress bar rescales accordingly.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.