scikit-learn / scikit-learn/scikit-learn
[Callbacks] ENH Avoid repeating the no callback support warning
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 67.3k
- Forks
- 27.4k
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 58
Description
see https://github.com/scikit-learn/scikit-learn/pull/28760#discussion_r2787769530
related to https://github.com/scikit-learn/scikit-learn/issues/27676
We raise a warning for an estimator not implementing callback support within a meta-estimator that has callbacks registered.
Currently this warning is repeated each time the inner estimator is cloned and fitted which can mean a lot of times.
It would be nice to avoid this repetion for clones of a same estimator.
ping @FrancoisPgm
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the discussion in PR #28760 and the related issue #27676 to understand the existing callback-support warning. Trace where the warning is emitted when cloned inner estimators are fitted, then add coverage showing that clones of the same estimator do not repeat it. Done means repeated cloning and fitting produces the warning only as intended.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- machine-learning
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100