scikit-learn / scikit-learn/scikit-learn
KMeans(init='k-means++') performance issue with OpenBLAS
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 67.3k
- Forks
- 27.4k
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 58
Description
I open this issue to investigate a performance problem that might be related to #17230.
I adapted the reproducer of #17230 to display more info and make it work on a medium-size random dataset.
from sklearn import cluster
from time import time
from pprint import pprint
from threadpoolctl import threadpool_info
import numpy as np
pprint(threadpool_info())
rng = np.random.RandomState(0)
data = rng.randn(5000, 50)
t0_global = time()
for k in range(1, 15):
t0 = time()
# print(f"Running k-means with k={k}: ", end="", flush=True)
cluster.KMeans(
n_clusters=k,
random_state=42,
n_init=10,
max_iter=2000,
algorithm='lloyd',
init='k-means++').fit(data)
# print(f"{time() - t0:.3f} s")
print(f"Total duration: {time() - t0_global:.3f} s")
I tried to run this on Linux with scikit-learn master (therefore including the #16499 fix) with 2 different builds of scipy (with openblas from pypi and MKL from anaconda) and various values for OMP_NUM_THREADS (unset, OMP_NUM_THREADS=1, OMP_NUM_THREADS=2, OMP_NUM_THREADS=4) on a laptop with 2 physical cpu cores (4 logical cpus).
In both cases, I use the same scikit-learn binaries (built with GCC in editable mode). I just change the env.
The summary is:
- with MKL there is no problem: large or unset values of
OMP_NUM_THREADSare faster thanOMP_NUM_THREADS=1; - with OpenBLAS without explicit setting of
OMP_NUM_THREADSor setting a large value for it is significanlty slower forced sequential run withOMP_NUM_THREADS=1.
I will include my runs in the first comment.
/cc @jeremiedbb
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the provided cluster.KMeans reproducer and threadpool_info output, varying OMP_NUM_THREADS as described. Compare the OpenBLAS and MKL runs on the stated dataset and determine whether the slowdown is specific to KMeans with k-means++ initialization; done means the cause and a reproducible performance impact are established.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- numpy, python
- Domain
- machine-learning, performance
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 45/100