scikit-learn / scikit-learn/scikit-learn
API: do we allow a list of generic objects as X?
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 67.3k
- Forks
- 27.4k
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 58
Description
https://github.com/scikit-learn/scikit-learn/pull/15557 introduced a change in the GP module to allow a list of generic objects and kernels on those data, which is nice, but it violates our API AFAIK.
If we're going to allow that, there are many other places we can/should allow that as well (SVMs for instance).
But that doesn't really play well with the rest of the library (pipeline, GS, etc).
ping @scikit-learn/core-devs
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Begin by reviewing scikit-learn pull request #15557 and the GP module behavior it introduced for lists of generic objects and kernels. Compare that behavior with SVMs, pipeline, and grid search, then establish whether generic-object inputs should be supported consistently or rejected; done means the API policy and affected components are clearly decided.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api, machine-learning
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100