scikit-learn / scikit-learn/scikit-learn
[RFC] Deprecate n_samples_seen_ in MaxAbsScaler and MinMaxScaler
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 67.3k
- Forks
- 27.4k
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 58
Description
MinMaxScaler and MaxAbsScaler have an attribute n_samples_seen which is not used to compute the statistics. For instance this is useful to have it in StandardScaler but does not bring anything in those 2 scalers.
In #11011, @jnothman proposed to deprecate this parameter which I am also in favor of.
@amueller @ogrisel Any opinion and historical reasons why this attribute is there (because the class have a partial_fit method?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the MinMaxScaler and MaxAbsScaler implementations and the discussion in #11011. Check how n_samples_seen_ is exposed and whether partial_fit depends on it, then establish the deprecation behavior and affected tests before making the change. Done means the unused attribute is deprecated consistently without altering scaler statistics.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- machine-learning
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100