scala / scala/scala-java8-compat

genjavadoc issue with StreamShapeLowPriority

Open
#160 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Scala
Stars
438
Forks
63
Avg merge
5h 12m
Merged PRs (30d)
2

Description

Recent travis build: https://travis-ci.org/scala/scala-java8-compat/builds/582046003

The 2.12.8 and 2.11.12 versions show:

[error] /home/travis/build/scala/scala-java8-compat/target/java/scala/compat/java8/StreamShapeLowPriority.java:3:1:  error: illegal combination of modifiers: public and protected
[error]   protected abstract class BaseStreamShape<T extends java.lang.Object, S extends java.util.stream.BaseStream<?, S>, St extends scala.compat.java8.collectionImpl.Stepper<?>> implements scala.compat.java8.StreamShape<T, S> {
[error]                      ^

The generated file: https://gist.github.com/lrytz/899f08e00d48ca14a4943bcfe834e38e

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked Travis build and inspect the generated target/java/scala/compat/java8/StreamShapeLowPriority.java shown in the report, then trace which genjavadoc step produces it for Scala 2.12.8 and 2.11.12. Reproduce the generation and determine why the public and protected modifiers appear together; done means the generated file compiles without the reported illegal-modifier error.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, scala
Domain
build-system, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.