sbt / sbt/sbt-javaagent

Putting agent JARs in lib directory

Open
#22 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Scala
Stars
68
Forks
21
Avg merge
2h 35m
Merged PRs (30d)
3

Description

Any particular reason that the agent JARs are not in the lib directory along with all the other dependencies?

Instead of:

addJava "-javaagent:${app_home}/../kanela-agent/kanela-agent-1.0.9.jar" 

it could be:

addJava "-javaagent:${lib_dir}/kanela-agent-1.0.9.jar" 

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the addJava invocation that currently uses app_home/../kanela-agent and inspect how the agent JARs and lib_dir are assembled. Confirm whether the existing packaging and tests cover the agent location; done means the agent JARs are placed in lib and the Java-agent path uses lib_dir without breaking the plugin.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, scala
Domain
build-system, tooling
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.