sbt / sbt/sbt-javaagent

Integration with sbt-revolver

Open
#11 0 comments 9 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Scala
Stars
68
Forks
21
Avg merge
2h 35m
Merged PRs (30d)
3

Description

Right now it seems to be possible to use sbt-javaagent with sbt-revolver like this (by stealing agentOptions:

javaOptions in reStart ++= resolvedJavaAgents.value map { resolved =>
  "-javaagent:" + resolved.artifact.absolutePath + resolved.agent.arguments
}

Would it make sense to expose agentOptions as a TaskKey to enable a nice little shortcut?

That is, something like:

javaOptions in reStart ++= agentOptions.value

If this sounds acceptable, I can submit a PR.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/main/scala/com/lightbend/sbt/javaagent/JavaAgent.scala around the referenced agentOptions definition, and compare it with sbt-revolver's reStart settings. The issue is done when agentOptions is exposed as a TaskKey usable by javaOptions in reStart, as shown in the proposed snippet.

Written by the indexing model from the issue text.

Assessment

Tech stack
scala
Domain
build-system, tooling
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.