Use `SizeParser` to correctly parse and validate `windows.PageFileFix` fields
Nobody has claimed this yet.
- Dominant language
- Scala
- Stars
- 199
- Forks
- 67
- Avg merge
- 6h 24m
- Merged PRs (30d)
- 3
Description
In https://github.com/sbt/sbt-github-actions/pull/146 we implemented windows.PageFileFix using bare String's which means its possible to put in incorrect values. Ideally we should use https://github.com/sbt/sbt/blob/973cd63e0b6bfe0d06d364f314f391a08a77d38b/internal/util-complete/src/main/scala/sbt/internal/util/complete/SizeParser.scala however its (largely) blocked by https://github.com/sbt/sbt-github-actions/issues/147 (its possible to work around this but its not nice).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing pull request 146 to see how windows.PageFileFix fields were introduced, then read SizeParser.scala and issue 147 to understand the dependency blocking its use. Confirm the accepted size syntax and validation behavior, and consider how the existing String fields should be replaced. Done means incorrect PageFileFix values are rejected through SizeParser without bypassing the issue 147 constraint.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions, scala
- Domain
- ci-cd
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100