plot: fix limits handling, unknown kwargs and a old docstring reference
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 72/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- numpy, python
- Domain
- data-visualization, documentation, testing
Research direction
Start with prepare_for_plot and the pairplot/marginal_plot type hints, then add the regression test requested for ndarray limits. Review diag_kwargs, upper_kwargs, and lower_kwargs handling so unrecognised keys are no longer silent. Finally inspect sbi/analysis/plot.py:1336 and plot.py:2860-2862; done means the references match the defined option helper.
Written by the indexing model from the issue text.
Description
Follow-up to #1425, which PR #1631 largely delivered. These are the concrete items that survive, each small and independent:
prepare_for_plotcompareslimits == [], which is wrong for anp.ndarray. Use a length check, and align thepairplot/marginal_plottype hints. Needs a regression test.- Warn or raise on unrecognised keys in
diag_kwargs,upper_kwargsandlower_kwargs. A typo is currently silent. sbi/analysis/plot.py:1336points readers at_get_default_fig_kwargs(), and the deprecation message atplot.py:2862tells them to use it. That function does not exist. Only_get_default_optsis defined, atplot.py:2860.
- Dominant language
- Python
- Stars
- 865
- Forks
- 260
- Avg merge
- 4d 3h
- Merged PRs (30d)
- 5
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from sbi-dev/sbi
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
-
feature request
Difficulty 4/5 3-5 days Newbie friendliness 52/100
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
-
API changes architecture blocked diagnostics
Difficulty 5/5 Over a week Newbie friendliness 35/100
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 76/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
bancolombia/sentinel#23 ·
-
test md OpenCI
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
integration:quickjs org:external priority:backlog topic:code-interpreter topic:middleware type:feature
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
langchain-ai/deepagents#6450 ·
-
bug client
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100