VSCode Extension shows errors ignored by the config file.
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 48/100
Research direction
Start by reproducing the issue with the shown .squawk.toml and a migration in the VSCode language server, then trace how excluded_rules are loaded and applied. Done means the excluded require-timeout-settings diagnostic is absent while ban-drop-column remains visible.
Written by the indexing model from the issue text.
Description
squawk-vscode version: 2.28.1
I have a .squawk.toml at the top level of our repository:
assume_in_transaction = true
pg_version = "15"
excluded_paths = [
"migrations/0000_00_00_initial.sql"
]
excluded_rules = [
"require-timeout-settings",
"prefer-timestamptz",
"prefer-robust-stmts",
"require-concurrent-index-creation",
"require-concurrent-index-deletion",
]
The Squawk language server output starts with:
21:31:05 [0m[34m[INFO] [0musing config file path: /Users/dreid/src/repo/.squawk.toml
21:31:05 [0m[34m[INFO] [0mpg version: Some(Version { major: 15, minor: None, patch: None })
21:31:05 [0m[34m[INFO] [0mexcluded rules: [RequireTimeoutSettings, PreferTimestampTz, PreferRobustStmts, RequireConcurrentIndexCreation, RequireConcurrentIndexDeletion]
21:31:05 [0m[34m[INFO] [0mexcluded paths: ["migrations/0000_00_00_initial.sql"]
21:31:05 [0m[34m[INFO] [0massume in a transaction: true
21:31:05 [0m[34m[INFO] [0mno error on unmatched pattern: false
21:31:05 [0m[34m[INFO] [0mStarting Squawk LSP server
Meanwhile a new migration displays:
I would expect to only see the ban-drop-column issue and not the require-timeout-settings issue that is part of the excluded_rules in the config file.
- Dominant language
- Rust
- Stars
- 1.2k
- Forks
- 70
- Avg merge
- 52m
- Merged PRs (30d)
- 47
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from sbdchd/squawk
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 48/100
-
enhancement
Difficulty 3/5 1-2 days Newbie friendliness 58/100
-
enhancement
Difficulty 3/5 1-2 days Newbie friendliness 56/100
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 35/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
kwakseongjae/auto-hwp#319 ·
-
area:cli bug filter-quality good first issue priority:medium
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
bevyengine/bevy#25861 ·
-
comp-datalake
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
ClickHouse/ClickHouse#121222 ·
-
enhancement remote
Difficulty 2/5 1-3 hours Newbie friendliness 68/100