Squawk ignores excludes in the config file when excludes are passed on the cli
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
Research direction
Start by tracing how the CLI --exclude values and configuration-file excludes are parsed and combined. Check the existing handling around those entry points, then add coverage for both sources being supplied; done means configured and command-line excludes are both honored consistently.
Written by the indexing model from the issue text.
Description
When using the --exclude command line flag, Squawk ignores excludes that were loaded from the config file.
To me this is unexpected (other linters that I've used combine those), and makes the config file less useful (to me).
Is there a use case for ignoring the excludes from the config file, or can we just combine the excludes?
This issue has been mentioned before in https://github.com/sbdchd/squawk/pull/213:
One case that I have not covered here is if the user wants to use both the CLI flags and the config file, one solution for this case would be to use the -c/--config flag together with the --exclude flag to signal the program that the user wants to merge those two together, but it's not a change that I want to do in this PR and it would be beneficial to reach an agreement with the contributors/community before deciding on a way to handle this case.
- Dominant language
- Rust
- Stars
- 1.2k
- Forks
- 70
- Avg merge
- 52m
- Merged PRs (30d)
- 47
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from sbdchd/squawk
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 48/100
-
enhancement
Difficulty 3/5 1-2 days Newbie friendliness 58/100
-
enhancement
Difficulty 3/5 1-2 days Newbie friendliness 56/100
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 35/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
kwakseongjae/auto-hwp#319 ·
-
area:cli bug filter-quality good first issue priority:medium
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
bevyengine/bevy#25861 ·
-
comp-datalake
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
ClickHouse/ClickHouse#121222 ·
-
enhancement remote
Difficulty 2/5 1-3 hours Newbie friendliness 68/100