satisfactorymodding / satisfactorymodding/ficsit-cli
Improve test data to not need modref mismatch bypass
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 69
- Forks
- 11
- PR merge metrics
- No merged PRs in 30d
Description
dde7f65658dabc8fa9d5d764ba5e33d0050de279
we should probably have mods made specifically for this and part of the ficsit-cli repo (they can be downloaded using file:// URLs most likely), or generated at runtime by the test and the test provides a small http endpoint to download them
But that's a job for later
so for now we allow mismatch?
Yeah, I just made it search for the first .uplugin in the zip, since the zips are validated by SMR anyway
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the test data and test that currently allow a mod reference mismatch, then inspect how the first .uplugin in a validated zip is selected. Compare the proposed file:// test mods or runtime-generated mods with the existing fixtures; done means the tests use appropriately named data without relying on the mismatch bypass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- testing-qa
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100