satisfactorymodding / satisfactorymodding/SatisfactoryModManager
Prevent "untracked files" situation by altering `.smm` marker file handling
Nobody has claimed this yet.
- Dominant language
- Svelte
- Stars
- 500
- Forks
- 94
- Avg merge
- 9d 19h
- Merged PRs (30d)
- 2
Description
If the mod manager encounters a problem while deleting mod files, it could end up leaving some of them behind but still delete the .smm marker file, making it think the folder is an unmanaged mod, leaving behind files that need to be cleaned up manually.
I think I've seen the untracked files issue before, and the solution is to have the
.smmmarker file be created before extracting any files, but be empty, then the hash written to it after the extraction is complete, and when uninstalling, it should be the last file deleted (i.e. delete all the contents of the folder first, except for that file, then delete the folder)
https://discord.com/channels/555424930502541343/1193986432574963782/1497328490167402576
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the code that creates and deletes .smm marker files, along with the mod extraction and uninstall entry points. Trace the failure paths around extraction and deletion; done means interrupted cleanup cannot make a folder appear unmanaged, and the marker lifecycle matches the behavior described in the issue.
Written by the indexing model from the issue text.
Assessment
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100