satisfactorymodding / satisfactorymodding/SatisfactoryModManager
Lower semver stable versions are considered valid updates to prereleases
Nobody has claimed this yet.
- Dominant language
- Svelte
- Stars
- 500
- Forks
- 94
- Avg merge
- 9d 19h
- Merged PRs (30d)
- 2
Description
For example, stable 1.3.0 is considered an "update" when the user has manually opted into pre-release 1.4.0-pre1.
It's a combination of the way SMM checks for updates and semver
When it checks for updates it sets all profile versions to *, which only matches releases
But when selecting a prerelease and checking "or newer" (i.e. >=x.y.z-pre.a), that would match only newer releases and same version prereleases, but SMM's update check has to set the range to *, otherwise it would never offer an update if the user selected a fixed version
https://discord.com/channels/555424930502541343/1193986432574963782/1403246938639433799
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are named. Start by locating the update-check path and the semver range construction, then reproduce the case where stable 1.3.0 is offered after opting into 1.4.0-pre1. Done means lower stable versions are no longer reported as updates while valid newer releases remain available.
Written by the indexing model from the issue text.
Assessment
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100