satisfactorymodding / satisfactorymodding/SatisfactoryModLoader

Crash on launch if any mods installed

Open
#95 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

cantfix
Dominant language
C++
Stars
344
Forks
225
PR merge metrics
No merged PRs in 30d

Description

Hi, this issue only started recently. If I launch Satisfactory with mods enabled, I get the following crash (UE4 crash reporter):


Version: 159365, IsEditor: No, IsPerforceBuild: No, BuildConfiguration: Shipping, Launcher: Steam, NetMode: -, IsUsingMods: Yes

Fatal error: [File:C:/jnk/workspace/SML2_master/SML/Plugins/SML/Source/SML/Private/Patching/NativeHookManager.cpp] [Line: 44] Hooking function AFGSchematicManager::PopulateSchematicsLists failed: funchook failed: Failed to execute VirtualQuery (addr=0x7fffffff0000, error=87(The parameter is incorrect.))

FactoryGame_SML_Win64_Shipping!FNativeHookManagerInternal::RegisterHookFunction() [C:\jnk\workspace\SML2_master\SML\Plugins\SML\Source\SML\Private\Patching\NativeHookManager.cpp:78]
FactoryGame_SML_Win64_Shipping!AModContentRegistry::DisableVanillaContentRegistration() [C:\jnk\workspace\SML2_master\SML\Plugins\SML\Source\SML\Private\Registry\ModContentRegistry.cpp:112]
FactoryGame_SML_Win64_Shipping!FSatisfactoryModLoader::InitializeModLoading() [C:\jnk\workspace\SML2_master\SML\Plugins\SML\Source\SML\Private\SatisfactoryModLoader.cpp:194]
FactoryGame_SML_Win64_Shipping!TBaseStaticDelegateInstance<void __cdecl(void)>::ExecuteIfSafe() [C:\jnk\workspace\SML2_master\ue4\Engine\Source\Runtime\Core\Public\Delegates\DelegateInstancesImpl.h:859]
FactoryGame_Win64_Shipping!TBaseMulticastDelegate::Broadcast() [d:\ws\sb-lowprio\ue4\engine\source\runtime\core\public\delegates\delegatesignatureimpl.inl:1013]
FactoryGame_Win64_Shipping!FEngineLoop::Init() [d:\ws\sb-lowprio\ue4\engine\source\runtime\launch\private\launchengineloop.cpp:4057]
FactoryGame_Win64_Shipping!GuardedMain() [d:\ws\sb-lowprio\ue4\engine\source\runtime\launch\private\launch.cpp:155]
FactoryGame_Win64_Shipping!GuardedMainWrapper() [d:\ws\sb-lowprio\ue4\engine\source\runtime\launch\private\windows\launchwindows.cpp:137]
FactoryGame_Win64_Shipping!WinMain() [d:\ws\sb-lowprio\ue4\engine\source\runtime\launch\private\windows\launchwindows.cpp:268]
FactoryGame_Win64_Shipping!__scrt_common_main_seh() [d:\agent_work\2\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288]
kernel32
ntdll


To note, I found a workaround is to start SMM in Administrator mode, but I never had to do this before.
This issue still happens following;

  1. Verifying Steam files
  2. Uninstalling and re-downloading mods
  3. Reinstalling SMM

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with SML/Plugins/SML/Source/SML/Private/Patching/NativeHookManager.cpp at lines 44 and 78, then trace the call from ModContentRegistry.cpp line 112 during FSatisfactoryModLoader::InitializeModLoading. Reproduce the crash with mods enabled and compare behavior with and without administrator mode; done means launch no longer crashes under the reported conditions.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, unreal-engine
Domain
game-dev, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.