sassoftware / sassoftware/python-sasctl
Older examples needs to be updated for JSONFiles API changes
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 52
- Forks
- 45
- Avg merge
- 23h 38m
- Merged PRs (30d)
- 2
Description
Describe the issue
This example has some API calls that don't work with the updated version of sasctl - changes to JSONFiles:
https://github.com/sassoftware/python-sasctl/blob/master/examples/pzmmCompleteModelExampleMLFlowSklearn.ipynb
For example, writeModelPropertiesJSON is now write_model_properties_json and has many changes in the parameters.
Other examples:
writeFileMetadataJSON
writeVarJSON
I checked other examples and it seems any of them 6 months or older are now out of date with the newer sasctl API.
To Reproduce
Run this command using latest sasctl
J.writeVarJSON(inputsDict, isInput=True, jPath=zipFolder)
and you will get things like
AttributeError: 'JSONFiles' object has no attribute 'writeVarJSON'. Did you mean: 'write_var_json'?
Version
The SHA is 729e72c8785065109ccfd1ffdb9816d4bf1dce55
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with examples/pzmmCompleteModelExampleMLFlowSklearn.ipynb and compare its JSONFiles calls with the current sasctl API. Search the other examples for writeModelPropertiesJSON, writeFileMetadataJSON, and writeVarJSON, then update outdated calls and parameters. Done means older examples run with the latest sasctl without the reported AttributeError.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100