sanger / sanger/sequencescape

Y26-109 - [BUG] Re-uploading a multiplexed library manifest that was originally blank causes an error

Open
#5,656 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Bug Size: S Value: 2
Dominant language
Ruby
Stars
111
Forks
34
Avg merge
4d 1h
Merged PRs (30d)
29

Description

Describe the bug
Re-uploading a multiplexed library manifest that was originally blank causes an error

FreshSerivce/RT Ticket Number
59413

To Reproduce
Steps to reproduce the behaviour:

  1. Go to multiplexed library manifest creation and upload a blank one
  2. Fill in the multiplexed library manifest with valid data and reupload it
  3. See error and cancelled library creation requests

Expected behaviour
The multiplexed library manifest uploads successfully.
Creation requests are not cancelled.

Image

Additional context
This is an edge case. The cancelling requests is to prevent reuploading from partial manifests as downstream tubes would be incorrect. However blank manifests should in theory have no downstream data so should be safe to update.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the multiplexed library manifest creation and upload flow, then reproduce the issue by uploading a blank manifest followed by a valid manifest. Done means the second upload succeeds and library creation requests are not cancelled, while preserving the safeguard against partial manifests.

Written by the indexing model from the issue text.

Assessment

Tech stack
rails, ruby
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.