reserved identifier violation

Open
#644 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
c
Domain
backend

Research direction

Start with the header guards at cram/cram_samtools.h:31 and htslib/klist.h:26, then inspect nearby naming patterns and search for related reserved identifiers. Done means the affected identifiers use unique names that comply with the C language standard, with no remaining instances of the reported names.

Written by the indexing model from the issue text.

Description

I would like to point out that identifiers like “_CRAM_SAMTOOLS_H_” and “_AC_KLIST_Hdo not fit to the expected naming convention of the C language standard.
Would you like to adjust your selection for unique names?

Dominant language
C
Stars
950
Forks
475
Avg merge
3d 13h
Merged PRs (30d)
11

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from samtools/htslib

All issues in samtools/htslib

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.