CRAM: quality "*" is stored inefficiently.

Open
#356 0 comments 0 reactions 1 assignee View on GitHub

@jkbonfield is already working on this.

Since Mar 18, 2016.

Assessment

This issue has not been assessed yet.

Description

enhancement

Cramtools clears CF bit 1 (quality scores stored as an array) to omit storage of quality values in such cases. Htslib/Scramble keeps CF bit 1 set and stores an array of value 255 (the BAM approach).

It compresses well of course, but it's an unnecessary thing to do and potentially could lead to inconsistencies in behaviour as it's harder for us to spot interoperability errors than errors within our own package.

Dominant language
C
Stars
950
Forks
475
Avg merge
3d 13h
Merged PRs (30d)
11

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from samtools/htslib

All issues in samtools/htslib

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.