bcf_has_filter

Open
#186 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
38/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
c
Domain
bioinformatics

Research direction

Start with the source implementation and documentation for bcf_has_filter, then compare its handling of FILTER=. and PASS with the VCFv4.2 specification. Check any existing tests covering FILTER values; done means the function's behavior is resolved against the specification and covered by an appropriate regression test.

Written by the indexing model from the issue text.

Description

D3: Easy P3: Low priority question

From the source, I notice that if FILTER is . and when PASS is queried, bcf_has_filter will return true. I understand that the documentation states that explicitly, but based on VCFv4.2 specification, it does not mention that . is equivalent to a PASS.

I think in this case, bcf_has_filter should return 0.

Dominant language
C
Stars
950
Forks
475
Avg merge
3d 13h
Merged PRs (30d)
11

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from samtools/htslib

All issues in samtools/htslib

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.