sameersbn / sameersbn/docker-gitlab
Avoid exposing volumes for compatibility with volumes drivers (convoy-nfs)
Nobody has claimed this yet.
- Dominant language
- Shell
- Stars
- 8.1k
- Forks
- 2.1k
- Avg merge
- 17h 47m
- Merged PRs (30d)
- 7
Description
Whatever docker volume driver you select when you start a container, the declared volumes from Dockerfile of the image are automatically mounted with this driver. You cannot select or unselect the ones you want.
In a configuration where someone would like two gitlab instances in multi master, the first volume (GITLAB_DATA_DIR) is wanted to be plugged with the volume driver (so you can share the volume between your containers)
But the log volume is not meant to be shared between the two containers.
As the volumes can be defined at runtime, with docker-compose.yml or in command line, would it be possible to remove the GITLAB_LOG_DIR from this line ?
https://github.com/sameersbn/docker-gitlab/blob/master/Dockerfile#L52
Thanks for your great job @sameersbn
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with Dockerfile at line 52, where GITLAB_LOG_DIR is declared. Check how the image currently declares its volumes and how runtime configuration through docker-compose.yml or the command line is expected to work. Done means the log volume is no longer forced through the selected volume driver while runtime volume definitions remain usable.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker
- Domain
- devops, infrastructure
- Issue type
- Feature
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 25/100