sameersbn / sameersbn/docker-gitlab

HTTPS behind a reverse proxy has some issue

Open
#724 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

wontfix
Dominant language
Shell
Stars
8.1k
Forks
2.1k
Avg merge
17h 47m
Merged PRs (30d)
7

Description

Hello Docker Gitlab team,

I'm currently trying to update from a 7.4.3 to the 8.8.3 version (with a temporary step on a 8.0.5-1 version, due to some other issues)

Previously my docker-gitlab was setup behind a reverse-proxy deserved with another Docker apache container with this config:

docker run  \
        --name=gitlab \
        --detach=true \
        --restart=always \
        -v /srv/gitlab/data:/home/git/data \
        --link postgresql:postgresql \
        --link redis:redisio \
        -p 22222:22 \
        -e 'GITLAB_HTTPS=true' \
        -e 'GITLAB_PORT=443' \
        -e 'GITLAB_HOST=gitlab.domain.com' \
        -e 'DB_NAME=gitlabhq_production' \
        -e 'DB_USER=gitlab' \
        -e 'DB_PASS=db_password' \
        -e 'LDAP_ENABLED=true' \
        -e 'LDAP_HOST=activedirectory.domain.local' \
        -e 'LDAP_PORT=3268' \
        -e 'LDAP_BIND_DN=CN=bind_user,CN=Users,DC=DOMAIN,DC=local' \
        -e 'LDAP_PASS=bind_password' \
        -e 'LDAP_ACTIVE_DIRECTORY=true' \
        -e 'LDAP_BASE=OU=Users,OU=MyBusiness,DC=DOMAIN,DC=local'  \
        -e 'LDAP_METHOD=plain'  \
        -e 'GITLAB_CREATE_GROUP=false' \
         sameersbn/gitlab:7.4.3

With this configuration the internal nginx server was mounting an available 443 virtualhost, so that the Reverse-proxy can access with its own SSL setup (certificates, ...).

Since the migration to 8.8.3 the config has slighty changed but I'm not able to mount the SSL anymore ?

The new config is now based on docker-compose :

gitlab_data:
  image: sameersbn/gitlab:8.8.3
  entrypoint: /bin/true
  container_name: gitlab_data
gitlab:
  image: sameersbn/gitlab:8.8.3
  container_name: gitlab
  restart: always
  volumes_from:
   - gitlab_data
  links:
   - "postgres:postgres"
   - "redis:redis"
  env_file: gitlab.env
  ports:
   - "22222:22"

And the env-file:

#DEBUG=true

GITLAB_HOST=gitlab.domain.com
GITLAB_PORT=443
GITLAB_HTTPS=true
GITLAB_SSH_PORT=22222
SSL_SELF_SIGNED=false

GITLAB_SECRETS_DB_KEY_BASE=XXXXXXXXXXXXXXXXXXXXXX

DB_HOST=postgres
DB_PORT=5432
DB_NAME=gitlabhq_production
DB_USER=gitlab
DB_PASS=db_password

LDAP_ENABLED=true
LDAP_HOST=activedirectory.domain.local
LDAP_PORT=3268
LDAP_BIND_DN=CN=bind_user,CN=Users,DC=DOMAIN,DC=local
LDAP_PASS=bind_password
LDAP_ACTIVE_DIRECTORY=true
LDAP_BASE=OU=Users,OU=MyBusiness,DC=DOMAIN,DC=local
LDAP_METHOD=plain

GITLAB_CREATE_GROUP=false

REDIS_HOST=redis
REDIS_PORT=6379

TZ=Europe/Paris
GITLAB_TIMEZONE=Paris

GITLAB_BACKUP_SCHEDULE=daily
GITLAB_BACKUP_TIME=01:00

Have you any clues on this ?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the older docker run configuration with the docker-compose definition and gitlab.env shown in the issue, focusing on the HTTPS, port, and SSL settings. Reproduce the upgrade configuration and document or correct the setup so the reverse proxy can reach GitLab over the intended HTTPS virtual host.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, docker-compose
Domain
devops, infrastructure, security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.