sameersbn / sameersbn/docker-gitlab

Doesn't restore from AWS S3 if backups is empty

Open
#314 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

wontfix
Dominant language
Shell
Stars
8.1k
Forks
2.1k
Avg merge
17h 47m
Merged PRs (30d)
7

Description

Seems there is no logic to check S3 if the /var/lib/docker/data/gitlab/backups/ directory is empty like on a fresh box, can this be implemented to check on restore of a backup?

What would be neater is on the restore rake to have a flag to automatically restore latest backup found without manually entering BACKUP=XXXXX

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the restore rake task and its handling of BACKUP, then trace how /var/lib/docker/data/gitlab/backups/ and AWS S3 are checked. Clarify whether the requested behavior is automatic lookup when the local directory is empty, a flag to restore the latest backup, or both; done should be defined by the agreed restore behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, docker, shell
Domain
cloud, devops
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.