sameersbn / sameersbn/docker-gitlab
When SSL is enabled, use "gitlab-ssl" as actual site configuration file name
Nobody has claimed this yet.
- Dominant language
- Shell
- Stars
- 8.1k
- Forks
- 2.1k
- Avg merge
- 17h 47m
- Merged PRs (30d)
- 7
Description
It would be really nice if we kept the filename the same as it exists in the assets subdirectory. It helps give me confirmation, when troubleshooting, that the proper configuration loaded. Ran into this when deploying into production and wasn't sure why the "gitlab-ssl" file didn't exist then read through init and saw why.
This is more of a nitpicky thing but I think it would bring great value to people who are working pretty intimately with this great image :)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Check the assets subdirectory and the init script references first, since the issue identifies both as relevant locations. Done means the SSL-enabled site configuration uses the gitlab-ssl filename consistently, matching the asset name and making the loaded configuration easier to verify.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, shell
- Domain
- devops
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100