sameersbn / sameersbn/docker-gitlab
In 16.6.0 /home/git/gitlab/lib/gitlab/redis/wrapper.rb is broken
Open
Nobody has claimed this yet.
- Dominant language
- Shell
- Stars
- 8.1k
- Forks
- 2.1k
- Avg merge
- 17h 47m
- Merged PRs (30d)
- 7
Description
Title says it all.
/home/git/gitlab/lib/gitlab/redis/wrapper.rb is broken in the 16.6.0 docker image.
This was the result ...
2023-11-23 23:38:55,814 INFO spawned: 'mail_room' with pid 3164
2023-11-23 23:38:57,248 INFO success: mail_room entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2023-11-23 23:39:00,612 INFO exited: mail_room (exit status 1; not expected)
2023-11-23 23:39:01,603 INFO spawned: 'mail_room' with pid 3165
2023-11-23 23:39:02,605 INFO success: mail_room entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2023-11-23 23:39:05,565 INFO exited: mail_room (exit status 1; not expected)
2023-11-23 23:39:06,568 INFO spawned: 'mail_room' with pid 3166
2023-11-23 23:39:07,570 INFO success: mail_room entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2023-11-23 23:39:10,931 INFO exited: mail_room (exit status 1; not expected)
2023-11-23 23:39:11,935 INFO spawned: 'mail_room' with pid 3170
2023-11-23 23:39:12,937 INFO success: mail_room entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2023-11-23 23:39:15,795 INFO exited: mail_room (exit status 1; not expected)
2023-11-23 23:39:16,797 INFO spawned: 'mail_room' with pid 3180
2023-11-23 23:39:17,800 INFO success: mail_room entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2023-11-23 23:39:20,808 INFO exited: mail_room (exit status 1; not expected)
2023-11-23 23:39:21,811 INFO spawned: 'mail_room' with pid 3181
2023-11-23 23:39:22,814 INFO success: mail_room entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2023-11-23 23:39:25,763 INFO exited: mail_room (exit status 1; not expected)
2023-11-23 23:39:26,766 INFO spawned: 'mail_room' with pid 3182
2023-11-23 23:39:27,793 INFO success: mail_room entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2023-11-23 23:39:30,856 INFO exited: mail_room (exit status 1; not expected)
2023-11-23 23:39:31,859 INFO spawned: 'mail_room' with pid 3183
2023-11-23 23:39:32,861 INFO success: mail_room entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2023-11-23 23:39:35,909 INFO exited: mail_room (exit status 1; not expected)
and so on and so on.
Getting a fresh wrapper.rb from gitlab fixed it for me.
I used this version of the file and notice no issue so far.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with /home/git/gitlab/lib/gitlab/redis/wrapper.rb in the 16.6.0 Docker image and compare it with the linked GitLab version. Reproduce the mail_room restart loop shown in the logs, then verify that the corrected wrapper prevents the repeated exits.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, ruby
- Domain
- backend, infrastructure
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100