sameersbn / sameersbn/docker-gitlab
README contradictory?
Nobody has claimed this yet.
- Dominant language
- Shell
- Stars
- 8.1k
- Forks
- 2.1k
- Avg merge
- 17h 47m
- Merged PRs (30d)
- 7
Description
The section Enabling HTTPS support describe
In this configuration, any requests made over the plain http protocol will automatically be redirected to use the https protocol. However, this is not optimal when using a load balancer.
but the section Using HTTPS with a load balancer describe
However, when using a load balancer you MUST set
GITLAB_HTTPStotrue. Additionally you will need to set theSSL_SELF_SIGNEDoption totrueif self signed SSL certificates are in use.
In my opinion this is contradictory. Do I miss something?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read the README sections "Enabling HTTPS support" and "Using HTTPS with a load balancer" first, then compare the conditions they describe. Determine whether the guidance is contradictory and update the README so the required load-balancer configuration and redirect behavior are clear.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, gitlab
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100