sameersbn / sameersbn/docker-gitlab
Support for azure_activedirectory_v2
Nobody has claimed this yet.
- Dominant language
- Shell
- Stars
- 8.1k
- Forks
- 2.1k
- Avg merge
- 17h 47m
- Merged PRs (30d)
- 7
Description
Hello!
It seems that for now only azure_oauth2 is supported which according to Microsoft's documentation doesn't support MFA and overall is an older endpoint.
Gitlab seems to now support azure_activedirectory_v2, however if we try to set OAUTH_ALLOW_SSO=azure_activedirectory_v2 it doesn't seem to take effect.
Are there any plans in the moment to add support for azure_activedirectory_v2?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the OAuth configuration that handles OAUTH_ALLOW_SSO and compare the existing azure_oauth2 path with the requested azure_activedirectory_v2 provider. Check the related GitLab and Microsoft documentation, then verify that the new provider setting is recognized and that the intended MFA-capable flow works.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- azure, docker
- Domain
- authentication, cloud
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100