SMTP_HOST and SMTP_PASS are very confusing

Hi everybody,

First of all, thanks for this awesome repository, I got gitlab working very fast with docker-compose.
Unfortunately, I struggled to configure SMTP all the morning.

As we are using Microsoft exchange in our company and the configuration is quite different to the default one, I had a look to gitlab configuration page : https://docs.gitlab.com/omnibus/settings/smtp.html

The thing is, I messed up a little bit, and I ended up with SMTP_ADDRESS and SMTP_PASSWORD env variables in my configuration instead of SMTP_HOST and SMTP_PASS.

I think it is very confusing to do not comply with gitlab's naming convension...
It would be a geat improvement if both SMTP_HOST and SMTP_ADDRESS where supported and to set gitlab's smtp_address configuration variable and SMTP_PASS and SMTP_PASSWORD for gitlab's smtp_password configuration variable.

It could be a good trade-off to keep working with existing configuration while being even more user friendly for new users (like me).

What do you think about this proposal ?

Thanks again for all the good work.

M0dM

No repository file or test is named in the issue. Start by searching the repository for SMTP_HOST, SMTP_PASS, smtp_address, and smtp_password, then inspect how environment variables are mapped into GitLab configuration. Done means the proposed aliases work while existing variable names remain supported, with coverage for the mappings if the project has relevant tests.