sameersbn / sameersbn/docker-gitlab
Add Letsencrypt support for Gitlab > 10.5
Nobody has claimed this yet.
- Dominant language
- Shell
- Stars
- 8.1k
- Forks
- 2.1k
- Avg merge
- 17h 47m
- Merged PRs (30d)
- 7
Description
Since version 10.5 Gitlab supports automatic letsencrypt connection:
https://about.gitlab.com/2018/02/22/gitlab-10-5-released/
According to https://docs.gitlab.com/omnibus/settings/ssl.html#let-39-s-encrypt-integration
there are only two lines to be added to /etc/gitlab/gitlab.rb:
letsencrypt['enable'] = true
letsencrypt['contact_emails'] = ['foo@email.com']
However, in this docker file the gitlab.rb is not located at /etc/gitlab/ and I guess it will be overriden by the environment variables anyway. How would I add these lines instead?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by checking how this Dockerized GitLab image supplies GitLab configuration and maps environment variables to gitlab.rb, especially since the issue says it is not at /etc/gitlab/. Compare that mechanism with GitLab's documented Let's Encrypt settings; done means users can enable Let's Encrypt and provide contact emails for GitLab versions above 10.5.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker
- Domain
- devops, infrastructure
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100