sameersbn / sameersbn/docker-gitlab

Are SSL_REGISTRY_CERT_PATH and GITLAB_REGISTRY_CERT_PATH the same thing?

Open
#1,390 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

wontfix
Dominant language
Shell
Stars
8.1k
Forks
2.1k
Avg merge
17h 47m
Merged PRs (30d)
7

Description

According to the docs here:

https://github.com/sameersbn/docker-gitlab/blob/master/docs/container_registry.md

There is this example which sets both SSL_REGISTRY* and GITLAB_REGISTRY* for key/certs. The documentation is confusing because it only shows how to generate the registry-auth.key and registry-auth.crt, but no examples that specifically reference registry.crt or registry.eky.

Looking at the code itself, it seems like these are actually both referencing the same value. I am not sure if this is a documentation bug or if I am just misunderstanding something.

docker run --name gitlab -d [PREVIOUS_OPTIONS] \
-v /srv/gitlab/certs:/certs \
--env 'SSL_REGISTRY_CERT_PATH=/certs/registry.crt' \
--env 'SSL_REGISTRY_KEY_PATH=/certs/registry.key' \
--env 'GITLAB_REGISTRY_ENABLED=true' \
--env 'GITLAB_REGISTRY_HOST=registry.gitlab.example.com' \
--env 'GITLAB_REGISTRY_API_URL=http://registry:5000/' \
--env 'GITLAB_REGISTRY_CERT_PATH=/certs/registry-auth.crt' \
--env 'GITLAB_REGISTRY_KEY_PATH=/certs/registry-auth.key' \
--link registry:registry
sameersbn/gitlab:10.0.4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with docs/container_registry.md and compare the SSL_REGISTRY_* and GITLAB_REGISTRY_* variables in the documented Docker example with the referenced code. Clarify whether the certificate and key paths are shared or distinct, and document the expected registry.crt, registry.key, registry-auth.crt, and registry-auth.key names.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, git
Domain
devops, documentation
Issue type
Documentation
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.